function show(modal) {
    modal.style.display = "block";
}

link.onclick = show(modal);
link2.onclick = show(modal2);

function show(modalId) {
    let modal = document.getElementById(modalId);
    modal.style.display = "block";
}

link.onclick = show('modal');
link2.onclick = show('modal2');