Как можно написать более нормально или упрощенно?

Question

[WarriorKodeK]

Привет
Как можно написать более нормально или упрощенно этот код ( а именноif else участок )?

const concatenateEditionFields = (
  pack: PackType,
  edition: IEditionMetadata,
  fieldName: string
) => {
  const packField = pack[fieldName]
  const editionField = edition[fieldName]
  const concatenated = `${packField || ''}${' '}${editionField ||
    ''}`.trimLeft()
  const isLanguageEqual =
    !edition.language || edition.language === pack.language

  if (isLanguageEqual) {
    return concatenated
  } else if (!isLanguageEqual && fieldName === 'slugline') {
    if (edition.addToPackSlug) {
      return concatenated
    } else {
      return editionField
    }
  } else {
    return editionField
  }
}

Answer 1

[Alexander Pushkarev]

const concatenateEditionFields = (
    pack: PackType,
    edition: IEditionMetadata,
    fieldName: string
) => {
    const packField = pack[fieldName] || '', 
        editionField = edition[fieldName] || '',
        concatenated = `${packField} ${editionField}`.trimLeft(),
        isLanguageEqual = !edition.language || edition.language === pack.language

    if (isLanguageEqual) {
        return concatenated
    } else if (fieldName === 'slugline') {
        return edition.addToPackSlug ? concatenated : editionField
    }

    return editionField
}

Answer 2

[Андрей Ламзин]

if (isLanguageEqual || edition.addToPackSlug) {
    return concatenated;
}
return editionField;

Answer 3

[DimaIs]

return isLanguageEqual ? concatenated : fieldName === 'slugline' ? edition.addToPackSlug ? concatenated : editionField : editionField

Comments

[Karpion]

DimaIs, Вы бы хоть скобки расставили!
А лучше - раскидать по разным строчкам.