DJ CRUD Update?

Question

[BEKa T]

При переходе на страницу редактирования постов выдает ошибку, а теги без проблем можно изменить
хотя оба (пост, тег) используют один и тот же миксин

Traceback

Environment:


Request Method: GET
Request URL: http://127.0.0.1:8000/posts/new-post-1555763604/update/

Django Version: 2.1.5
Python Version: 3.7.2
Installed Applications:
['blog',
 'engine',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware']



Traceback:

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  126.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  124.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/generic/base.py" in view
  68.             return self.dispatch(request, *args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/generic/base.py" in dispatch
  88.         return handler(request, *args, **kwargs)

Exception Type: TypeError at /posts/new-post-1555763604/update/
Exception Value: get() got an unexpected keyword argument 'slug'

urls.py

from django.urls import path
from . views import *

urlpatterns = [
	path('', index, name='main_url'),

	path('posts/', post, name='posts_url'),
	path('posts/create/', PostCreate.as_view(), name='post_create_url'),
	path('posts/<str:slug>/update/', PostUpdate.as_view(), name='post_update_url'),
	path('posts/<str:slug>/', PostInfo.as_view(), name='post_url'),

	path('tags/', tag, name='tags_url'),
	path('tags/create/', TagCreate.as_view(), name='tag_create_url'),
	path('tags/<str:slug>/', TagInfo.as_view(), name='tag_url'),
	path('tags/<str:slug>/update/', TagUpdate.as_view(), name='tag_update_url'),
]

post_update.html

{% extends 'main/index.html' %}

{% block title %}
	Update post
{% endblock %}

{% block content %}



	<form action="{{ post.get_update_url }}" method="POST">
		
			{% csrf_token %}

			{% for field in form %}
			
				<div class="form-group">
					
					{% if field.errors %}
						<div class="alert alert-danger">{{ field.errors }}</div>
					{% endif %}
					
					{{ field.label }}
				    {{ field }}

				</div>
			{% endfor %}

		<a href=""><button type="submit" class="btn btn-primary">Изменить пост</button></a>

	</form>



{% endblock %}

Comments

[Roman K]

За тебя ошибку что-ли прочитать? Или может сам справишься?

[BEKa T]

Roman Kitaev, get () получил неожиданный аргумент ключевого слова 'slug'
и что это значит

[sim3x]

Bred Thomson, Ошибки лучше вставлять текстом

[Roman K]

Bred Thomson, get какой-то модели (ты не заскинил какой, но судя по урлу, вероятно Post) получил аргумент slug, но у модели нет такого поля, поэтому БД не сможет отфильтровать по этому полю.

[BEKa T]

Roman Kitaev, models.py

from django.db import models
from django.shortcuts import reverse
from django.utils.text import slugify
from time import time

def gen_slug(s):
	new_slug = slugify(s, allow_unicode=True)
	return new_slug + '-' + str(int(time()))



class Post(models.Model):
	title = models.CharField(max_length=150, db_index=True)
	slug = models.SlugField(max_length=150, blank=True, unique=True)
	body = models.TextField(blank=True, db_index=True)
	tags = models.ManyToManyField('Tag', blank=True, related_name='posts')
	date_pub = models.DateTimeField(blank=True, null=True)

	def get_absolute_url(self):
		return reverse('post_url', kwargs={'slug': self.slug})


	def get_update_url(self):
		return reverse('post_update_url', kwargs={'slug': self.slug})


	def save(self, *args, **kwargs):
		if not self.id:
			self.slug = gen_slug(self.title)
		super().save(*args, **kwargs)



	def __str__(self):
		return self.title


class Tag(models.Model):
	title = models.CharField(max_length=50)
	slug = models.SlugField(max_length=50, unique=True)

	def get_absolute_url(self):
		return reverse('tag_url', kwargs={'slug': self.slug})


	def get_update_url(self):
		return reverse('tag_update_url', kwargs={'slug': self.slug})

	def __str__(self):
		return self.title

[Roman K]

Bred Thomson, трейсбэк ошибки покажи. Чей get вызывается?

[BEKa T]

Roman Kitaev, Traceback

Environment:


Request Method: GET
Request URL: http://127.0.0.1:8000/posts/new-post-1555763604/update/

Django Version: 2.1.5
Python Version: 3.7.2
Installed Applications:
['blog',
 'engine',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware']



Traceback:

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  126.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  124.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/generic/base.py" in view
  68.             return self.dispatch(request, *args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/generic/base.py" in dispatch
  88.         return handler(request, *args, **kwargs)

Exception Type: TypeError at /posts/new-post-1555763604/update/
Exception Value: get() got an unexpected keyword argument 'slug'

[Roman K]

Bred Thomson, аааа, я кажется понял. Это get вьюхи. Какая-то вьюха объявляет метод

def get(self, request, ...):

И в ней нет slug

[BEKa T]

Roman Kitaev, views.py

from django.shortcuts import render, redirect, get_object_or_404
from django.views.generic import View

from . models import Post, Tag
from . utils import *
from . forms import PostForm, TagForm

def index(request):
	return render(request, 'main/index.html')

def post(request):
	posts = Post.objects.all()
	return render(request, 'blog/index.html', context={'posts': posts})

def tag(request):
	tags = Tag.objects.all()
	return render(request, 'blog/tags.html', context={'tags': tags})

class PostInfo(ObjectDetailMixin, View):
	model = Post
	template = 'blog/post.html'


class PostCreate(ObjectCreateMixin, View):
	model_form = PostForm
	template = 'blog/post_create.html'


class PostUpdate(ObjectCreateMixin, View):
	model = Post
	model_form = PostForm
	template = 'blog/post_update.html'





class TagInfo(ObjectDetailMixin, View):
	model = Tag
	template = 'blog/tag_info.html'


class TagCreate(ObjectCreateMixin, View):
	model_form = TagForm
	template = 'blog/tag_create.html'


class TagUpdate(ObjectUpdateMixin, View):
	model = Tag
	model_form = TagForm
	template = 'blog/tag_update.html'





	# def get(self, request, slug):
	# 	tag = Tag.objects.get(slug__iexact=slug)
	# 	bound_form = TagForm(instance=tag)
	# 	return render(request, 'blog/tag_update.html', context={'form': bound_form, 'tag': tag})

	# def post(self, request, slug):
	# 	tag = Tag.objects.get(slug__iexact=slug)
	# 	bound_form = TagForm(request.POST, instance=tag)

	# 	if bound_form.is_valid():
	# 		new_tag = bound_form.save()
	# 		return redirect(new_tag)
	# 	return render(request, 'blog/tag_update.html', context={'form': bound_form, 'tag': tag})

[BEKa T]

Roman Kitaev, может дело в миксине utils.py

from django.shortcuts import render, get_object_or_404, redirect

from . models import *

class ObjectDetailMixin:
	model = None
	template = None

	def get(self, request, slug):
	  	obj = get_object_or_404(self.model, slug__iexact=slug)
	  	return render(request, self.template, context={self.model.__name__.lower(): obj})



class ObjectCreateMixin:
	model_form = None
	template = None


	def get(self,request):
		form = self.model_form()
		return render(request, self.template, context={'form': form})

	def post(self, request):
		bound_form = self.model_form(request.POST)

		if bound_form.is_valid():
			new_obj = bound_form.save()
			return redirect(new_obj)

		return render(request, self.template, context={'form': bound_form})




class ObjectUpdateMixin:
	model = None
	model_form = None
	template = None

	def get(self, request, slug):
		obj = self.model.objects.get(slug__iexact=slug)
		bound_form = self.model_form(instance=obj)
		return render(request, self.template, context={'form': bound_form, self.model.__name__.lower(): obj})

	def post(self, request, slug):
		obj = self.model.objects.get(slug__iexact=slug)
		bound_form = self.model_form(request.POST, instance=obj)

		if bound_form.is_valid():
			new_obj = bound_form.save()
			return redirect(new_obj)
		return render(request, self.template, context={'form': bound_form, self.model.__name__.lower(): obj})

[Roman K]

Bred Thomson,

class ObjectCreateMixin:
  model_form = None
  template = None


  def get(self,request):
    form = self.model_form()
    return render(request, self.template, context={'form': form})

  def post(self, request):
    bound_form = self.model_form(request.POST)

    if bound_form.is_valid():
      new_obj = bound_form.save()
      return redirect(new_obj)

    return render(request, self.template, context={'form': bound_form})

def get(self,request):
    form = self.model_form()
    return render(request, self.template, context={'form': form})

Видишь, get не принимает slug?

[BEKa T]

Roman Kitaev, так у меня при создании поста все норм, а при обновление (ObjectUpdateMixin) выдает ошибку

[BEKa T]

Roman Kitaev, ааааааааааааааааааа!!!
СРАБОТАЛО!!!

[BEKa T]

Roman Kitaev, вы правы были добавил "slug" и заработало

def get(self,request, slug):
		form = self.model_form()
		return render(request, self.template, context={'form': form})

[BEKa T]

Roman Kitaev, но я не понимаю у него-то работал и без слага

[Roman K]

Bred Thomson,

Сперва советую выучить питон, прежде чем нырять в непонятные тебе фреймворки.

[BEKa T]

Roman Kitaev, теперь новый баг. При нажати на сабмит создается новый пост вместо замены

[Roman K]

Bred Thomson, потому что твоя логика так делает. Это не баг.

[BEKa T]

Roman Kitaev, после долгих размышлений я понял что ошибка не в том что я где-то забыл прописать слаг, а в этом

: (

class PostUpdate(ObjectCreateMixin, View):
	model = Post
	model_form = PostForm
	template = 'blog/post_update.html'

: )

class PostUpdate(ObjectUpdateMixin, View):
	model = Post
	model_form = PostForm
	template = 'blog/post_update.html'

ObjectCreateMixin ---> ObjectUpdateMixin